-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: creating queries and features, implementing on expenses, changed clippy allows to expect with reasons #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasauler
force-pushed
the
clippy-expect
branch
3 times, most recently
from
September 29, 2024 16:37
6d0666c
to
841d192
Compare
constraint, making user_id not null and removing default from date
refa: changed expenses data api to use the new structure
directly on datetimes, instead of selecting a month and us converting it for them
nicolasauler
force-pushed
the
clippy-expect
branch
from
September 29, 2024 16:39
841d192
to
f6a5e18
Compare
nicolasauler
changed the title
wip: creating queries and features, started changing clippy allows
feat: creating queries and features, implementing on expenses, changed clippy allows to expect with reasons
Sep 29, 2024
Codecov ReportAttention: Patch coverage is
|
feat: experimenting with passing things that implement pgexecutor to queries to support both connections and transactions
todo: - check forgot password - check change password - check confirm email and basically the whole auth flow
nicolasauler
force-pushed
the
clippy-expect
branch
4 times, most recently
from
September 30, 2024 02:37
6353924
to
0f6a7ed
Compare
nicolasauler
force-pushed
the
clippy-expect
branch
from
September 30, 2024 02:44
0f6a7ed
to
bed3e9b
Compare
nicolasauler
force-pushed
the
clippy-expect
branch
from
September 30, 2024 03:25
b5c5660
to
a6d19fc
Compare
nicolasauler
force-pushed
the
clippy-expect
branch
from
September 30, 2024 03:36
a6d19fc
to
a1dfc53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR starts the migration into an organized architecture, which will go something like:
Also, having this separation allowed us to begin testing, and this PR demonstrates this with the test of the create expense feature.
It also configures CI for testing, by provisioning a postgres database.
Finally, it uses the clippy expects and reasons that were stabilized in Rust 1.81 I think.
ToDo
Related issues
closes: #139
Starts resolving: